-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maccel scaledowncurve+roundingcarry #6
Conversation
642e264
to
97bbf32
Compare
This requires a documentation change, including breaking change instructions. |
I've pushed an attempt at documenting the changes. |
@Wimads Can you update the desmos image and link for the new formula? |
fa7de95
to
efa9af0
Compare
Note for self, from Discord:
|
7f7ab25
to
d79ecdb
Compare
Can you explain this part @finrod09 ? Throttling was necessary for myself to get my dragscroll implementation to work smoothly. Don't know what you mean with the linearity issue you describe here? Also the line above (116) is duplication, I moved that to the bit above the preceding code block. Guess that got back in from a merge conflict. |
Correct, I botched rebasing onto the spelling fix in maccel-dev. No content changes were intended. Since it is likely #8 will merge before this, I will get another chance at rebasing correctly. Edit: This was a result of this PR's history being convoluted and already containing merges that have to be manually resolved. We have let this PR linger too long and it has become bloated. A lesson for all involved, hopefully we'll do better next time :) |
Yeah I'm getting a lot of merge conflicts lately on this branch when syncing to my machine... Does this have to do with the spell check? All commits I did lately also got a spell check error. |
But what about that throttling part in the readme? Is that also something that got back in accidentally over a merge, or was that intentional? |
- updated *configuration* with new instructions for downscale curve - updated *limitations* , removed part about device specific parameter; added list of compatible sensors tested so far. - updated *breaking changes* with instructions for readjusting variables
…on to installation process.
c183e9f
to
c1c62c7
Compare
be1a705
to
ef443f6
Compare
Changing the acceleration math to scale down from default DPI instead of scaling up as before.
Adding a rounding carry to make it smooth at low speeds (credit: @ankostis )